Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit javascripts? #22

Closed
frank06 opened this issue Oct 7, 2010 · 7 comments
Closed

commit javascripts? #22

frank06 opened this issue Oct 7, 2010 · 7 comments

Comments

@frank06
Copy link

frank06 commented Oct 7, 2010

Including generated javascript adds a lot of noise when viewing/diffing commits.

Would it be smart to remove the lib folder altogether and add a compilation step when people install via npm? For those who clone the repo or download tarballs a simple coffee -wc --no-wrap -o lib src/*.coffee would do the trick.

@technoweenie
Copy link
Contributor

That requires users to have coffeescript to use our app. I definitely don't want that.

@frank06
Copy link
Author

frank06 commented Oct 7, 2010

If npm was the only way to get the source code that would've made more sense (coffee is not a huge dependency). But you're right that it would introduce a burden on users. Closing.

@technoweenie
Copy link
Contributor

Well, another thought is maybe the cs=>js conversion is part of the npm process. The git repo has no js, but npm is published with js files.

Though one other small point is the tests run against the compiled js files, IIRC. I think that approach helps to find any potential cs compilation issues.

@frank06
Copy link
Author

frank06 commented Oct 7, 2010

Oh... that's right! it could be done at publish time (we could have a simple bash script) but we would still be neglecting git cloners.

Re: the other small point, i think that won't happen. Through some mechanism (compiling to /tmp?) coffee executes your cs files in node without generating those .js files in the working directory. I believe by running a coffee file you are ensuring a successful compilation of that file and all recursively require()d ones.

@technoweenie
Copy link
Contributor

Ok, SOLD. Get that JS outta there.

@frank06
Copy link
Author

frank06 commented Oct 8, 2010

:)

Here's an attempt: http://github.com/frank06/riak-js/compare/no-js

@technoweenie
Copy link
Contributor

That looks good. The makefile is great too.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants