-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commit javascripts? #22
Comments
That requires users to have coffeescript to use our app. I definitely don't want that. |
If npm was the only way to get the source code that would've made more sense (coffee is not a huge dependency). But you're right that it would introduce a burden on users. Closing. |
Well, another thought is maybe the cs=>js conversion is part of the npm process. The git repo has no js, but npm is published with js files. Though one other small point is the tests run against the compiled js files, IIRC. I think that approach helps to find any potential cs compilation issues. |
Oh... that's right! it could be done at publish time (we could have a simple bash script) but we would still be neglecting git cloners. Re: the other small point, i think that won't happen. Through some mechanism (compiling to |
Ok, SOLD. Get that JS outta there. |
:) Here's an attempt: http://github.com/frank06/riak-js/compare/no-js |
That looks good. The makefile is great too. |
Including generated javascript adds a lot of noise when viewing/diffing commits.
Would it be smart to remove the
lib
folder altogether and add a compilation step when people install via npm? For those who clone the repo or download tarballs a simplecoffee -wc --no-wrap -o lib src/*.coffee
would do the trick.The text was updated successfully, but these errors were encountered: