do not override set vars with falsy values (#203)

motdotla · Jun 20, 2017 · 25bf5ad · 25bf5ad
1 parent 825c1b2
commit 25bf5ad
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/main.js b/lib/main.js
@@ -60,7 +60,9 @@ function config (options) {
     var parsedObj = parse(fs.readFileSync(path, { encoding: encoding }))
 
     Object.keys(parsedObj).forEach(function (key) {
-      process.env[key] = process.env[key] || parsedObj[key]
+      if (!process.env.hasOwnProperty(key)) {
+        process.env[key] = parsedObj[key]
+      }
     })
 
     return { parsed: parsedObj }

diff --git a/test/main.js b/test/main.js
@@ -74,6 +74,15 @@ describe('dotenv', function () {
       done()
     })
 
+    it('does not write over keys already in process.env if the key has a falsy value', function (done) {
+      process.env.test = ''
+      // 'val' returned as value in `beforeEach`. should keep this ''
+      dotenv.config()
+
+      process.env.test.should.eql('')
+      done()
+    })
+
     it('returns parsed object', function (done) {
       var env = dotenv.config()