Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore leading export for direnv. #112

Closed
AndersDJohnson opened this issue Dec 13, 2015 · 3 comments
Closed

Ignore leading export for direnv. #112

AndersDJohnson opened this issue Dec 13, 2015 · 3 comments

Comments

@AndersDJohnson
Copy link

It may be nice to add support that ignores leading export\s+ on each line, so that we can interoperate with direnv files.

@maxbeatty
Copy link
Contributor

The current regex should already ignore export\s+. If this isn't the case, please open a Pull Request with a failing test.

AndersDJohnson pushed a commit to AndersDJohnson/dotenv that referenced this issue Jan 8, 2016
AndersDJohnson pushed a commit to AndersDJohnson/dotenv that referenced this issue Jan 8, 2016
@AndersDJohnson
Copy link
Author

@maxbeatty I should have been more clear. I don't want it to skip the entire line, I want it to be able to strip leading export\s+ and parse the subsequent environment variable as usual.

See my pull request #118 for a fix.

@tiffany352
Copy link

I just lost like half an hour trying to debug why dotenv wasn't working in my project. It turns out it's because this library doesn't understand export lines. dotenv silently rejects these lines, without even giving so much as an error or warning.

Isn't the entire point of this library to replace the need for . .env to get the right environment variables? Why isn't this compatible with that basic format? Why was the PR not only closed, but then locked to prevent further discussion? I don't understand, and I'm frustrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants