Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme for react apps #179

Closed
wants to merge 1 commit into from
Closed

update readme for react apps #179

wants to merge 1 commit into from

Conversation

mrdougwright
Copy link

This tripped me up more than once, so I thought I'd suggest updating the readme. Thanks for your time :)

@coveralls
Copy link

coveralls commented Feb 20, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 0e2f4e6 on mrdougwright:react-readme-update into 825c1b2 on motdotla:master.

@maxbeatty
Copy link
Contributor

this is an implementation detail of react and I worry that by this example you're sending sensitive information like database connection details to the client 🙁

furthermore, I don't think dotenv should be encouraged for client use. other build tools like webpack includes plugins that do the same thing

@maxbeatty maxbeatty closed this Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants