Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support import.meta.url-style path URLs #303

Closed
wants to merge 1 commit into from
Closed

Support import.meta.url-style path URLs #303

wants to merge 1 commit into from

Conversation

ravinggenius
Copy link

Fixes #301

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0fe5eb6 on ravinggenius:import-meta-url into 1945a05 on motdotla:master.

@maxbeatty
Copy link
Contributor

Sorry ES modules are not playing nicely out of the box, but I feel pretty strongly that dotenv should follow Node core by requiring a valid "<string> | <Buffer> | <URL> | <integer> filename or file descriptor" for fs.readFileSync.

@maxbeatty maxbeatty closed this Apr 27, 2018
@ravinggenius
Copy link
Author

Understood. I opened an issue (nodejs/node#20357) with Node, so hopefully it will be fixed there.

@ravinggenius ravinggenius deleted the import-meta-url branch May 3, 2018 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ravinggenius @coveralls @maxbeatty