Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for Node v4 #304

Merged
merged 7 commits into from
Jun 2, 2018
Merged

drop support for Node v4 #304

merged 7 commits into from
Jun 2, 2018

Conversation

maxbeatty
Copy link
Contributor

@maxbeatty maxbeatty commented May 2, 2018

BREAKING CHANGE closes #282

thanks to rework in #302 switched to node-tap for tests which gives us all the same features in ~30% less LOC

  • upgrade dependencies
  • remove examples (need to be better)
  • don't change anything meaningful in lib/ (regex change was prompted by standard)

@maxbeatty maxbeatty self-assigned this May 2, 2018
@coveralls
Copy link

coveralls commented May 2, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 992d241 on node10 into 1945a05 on master.

@zenflow zenflow mentioned this pull request May 2, 2018
@maxbeatty
Copy link
Contributor Author

Can anyone with access to a Windows machine take a look at the failing CLI test? Maybe @zenflow since you originally helped add tests for appveyor?

@zenflow
Copy link

zenflow commented May 4, 2018

@maxbeatty Sure, would be a pleasure 👍 I can do this in a couple days

@zenflow
Copy link

zenflow commented May 7, 2018

Hmm. The tests work fine on my local machine..

C:\Users\Matt\Documents\dev\dotenv>npm t

> dotenv@5.0.1 pretest C:\Users\Matt\Documents\dev\dotenv
> npm run lint


> dotenv@5.0.1 lint C:\Users\Matt\Documents\dev\dotenv
> standard


> dotenv@5.0.1 postlint C:\Users\Matt\Documents\dev\dotenv
> npm run lint-md


> dotenv@5.0.1 lint-md C:\Users\Matt\Documents\dev\dotenv
> standard-markdown




> dotenv@5.0.1 test C:\Users\Matt\Documents\dev\dotenv
> tap tests/*.js --100

tests/test-cli-options.js ............................. 1/1 2s
tests/test-config-cli.js .............................. 1/1 2s
tests/test-config.js ................................ 13/13
tests/test-parse.js ................................. 16/16
total ............................................... 31/31

  31 passing (7s)

  ok
----------------------|----------|----------|----------|----------|-------------------|
File                  |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
----------------------|----------|----------|----------|----------|-------------------|
All files             |      100 |      100 |      100 |      100 |                   |
 lib                  |      100 |      100 |      100 |      100 |                   |
  cli-options.js      |      100 |      100 |      100 |      100 |                   |
  main.js             |      100 |      100 |      100 |      100 |                   |
 tests                |      100 |      100 |      100 |      100 |                   |
  test-cli-options.js |      100 |      100 |      100 |      100 |                   |
  test-config-cli.js  |      100 |      100 |      100 |      100 |                   |
  test-config.js      |      100 |      100 |      100 |      100 |                   |
  test-parse.js       |      100 |      100 |      100 |      100 |                   |
----------------------|----------|----------|----------|----------|-------------------|

C:\Users\Matt\Documents\dev\dotenv>node -v
v9.11.1

C:\Users\Matt\Documents\dev\dotenv>cmd -v
Microsoft Windows [Version 10.0.16299.371]
(c) 2017 Microsoft Corporation. All rights reserved.

Let me investigate some more...

@maxbeatty maxbeatty requested review from jcblw and motdotla May 7, 2018 17:42
@maxbeatty maxbeatty mentioned this pull request May 31, 2018
Copy link
Owner

@motdotla motdotla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks Max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for node version 4 and start using ES6 syntax
4 participants