Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package.json) : add the exact types file instead of the directory #476

Closed
wants to merge 1 commit into from
Closed

Conversation

axel-andre
Copy link

@axel-andre axel-andre commented Jul 8, 2020

This PR is here to solved the issue #475. This is an quick and easy fix at first proposed by @alexesprit.

This problem is actually pretty annoying when you are using VSCode. By pointing to index.d.ts directly we avoid the issue and it does not make any breaking change.

Again, pretty simple PR tho.

(First contribution ever, do not be afraid to tell me if anything is wrong !)

@OmgImAlexis
Copy link

@motdotla what's holding this up from being merged? If it's the tests can they please be re-run as this shouldn't be the cause of the failure.

@Anoesj
Copy link

Anoesj commented Nov 27, 2020

@motdotla Please merge this PR 🙃

@OmgImAlexis
Copy link

@motdotla can you please check on this issue. This would help a fair few people and it doesn’t break anything.

@axel-andre
Copy link
Author

The CI error is not caused by my single line edit. Is it possible to merge this ? Or at least answer here @motdotla when you have time

@olibooty
Copy link

While not an exact solution, I tend to use dotenv as part of a package.json script e.g. nodemon -r dotenv/config. No errors so far 🤷

@sirlancelot
Copy link

The bug described in #475 is affecting my project only when I open the file jsconfig.json in VSCode. My project doesn't directly depend on dotenv, it is included by one of my dependencies (@vue/cli-service).

I can confirm that applying this patch (setting types to the exact file instead of the directory) fixed the error.

According to TypeScript's official documentation for publishing, the types property must point to a file.

@OmgImAlexis
Copy link

@motdotla can you please check on this issue. It’s been a while since we last pinged you.

@motdotla
Copy link
Owner

motdotla commented May 5, 2021

this will be released here: #519

@motdotla motdotla closed this May 5, 2021
@axel-andre axel-andre deleted the fix/#475 branch May 25, 2021 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants