Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows debug #523

Merged
merged 1 commit into from
May 10, 2021
Merged

Windows debug #523

merged 1 commit into from
May 10, 2021

Conversation

motdotla
Copy link
Owner

@motdotla motdotla commented May 5, 2021

@paramsiddharth
Copy link

paramsiddharth commented May 6, 2021

ok, @paramsiddharth and @aetonsi this should be the fix: #523

would you mind testing it on your machines by installing the specific reference to that branch? [1]

[1] https://stackoverflow.com/questions/39732397/install-specific-branch-from-github-using-npm#39732501

OK, @motdotla ! I'll test it and report if it is fixed now.

@motdotla
Copy link
Owner Author

motdotla commented May 6, 2021

Great, thanks @paramsiddharth !

@motdotla motdotla force-pushed the master branch 3 times, most recently from fa35ecf to 0df4843 Compare May 9, 2021 00:08
@paramsiddharth
Copy link

@motdotla I have successfully tested and verified the current windows-debug branch to be working for .env files with of both LF and CRLF variants.

Here's my test: test.zip
imageimage
Worked both on Windows and Linux.

@motdotla
Copy link
Owner Author

awesome @paramsiddharth. appreciate all the help. merging shortly and bumping version.

@motdotla motdotla closed this May 10, 2021
@motdotla motdotla reopened this May 10, 2021
@motdotla motdotla merged commit 6d6b792 into master May 10, 2021
@motdotla motdotla deleted the windows-debug branch May 10, 2021 16:50
@motdotla
Copy link
Owner Author

This was just published as 9.0.2 @paramsiddharth. Thanks again. 🎩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants