Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run handler callback #282

Merged
merged 8 commits into from
May 17, 2017
Merged

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented May 17, 2017

Because Node.js 4.3 sometimes truncate on the way if the result size is
large
Because the value changes on Windows and Linux.
Because it is not executed unless you explicitly specify the node
command on Windows in case of executing in unit test.
Copy link
Collaborator

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 that's a nice fix to have. I wonder about the http://docs.aws.amazon.com/lambda/latest/dg/nodejs-prog-model-context.html#nodejs-prog-model-context-properties callbackWaitsForEmptyEventLoop, should we support it?

@DeviaVir DeviaVir merged commit b285b41 into motdotla:master May 17, 2017
@abetomo
Copy link
Contributor Author

abetomo commented May 17, 2017

I have not used Lambda with callbackWaitsForEmptyEventLoop set to false and I will check it.
If it seems to be able to support, I will try to fix it. :-)

@abetomo abetomo deleted the fix_run_handler_callback branch May 18, 2017 06:07
@DeviaVir DeviaVir mentioned this pull request Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants