Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support `meta name="go-import"` to detect Go repository #120

Merged
merged 4 commits into from Apr 26, 2019

Conversation

Projects
None yet
1 participant
@Songmu
Copy link
Collaborator

commented Apr 22, 2019

follow on #119

Before

% ghq get golang.org/x/crypto
     clone https://golang.org/x/crypto -> /Users/Songmu/dev/src/golang.org/x/crypto
       git ls-remote https://golang.org/x/crypto
        hg identify https://golang.org/x/crypto
       svn info https://golang.org/x/crypto
     error Could not find version control system: https://golang.org/x/crypto

After

$ ghq get golang.org/x/crypto
     clone https://golang.org/x/crypto -> /Users/Songmu/dev/src/golang.org/x/crypto
       git ls-remote https://golang.org/x/crypto
       git clone https://go.googlesource.com/crypto /Users/Songmu/dev/src/golang.org/x/crypto
Cloning into '/Users/Songmu/dev/src/golang.org/x/crypto'...
remote: Total 5013 (delta 2982), reused 5013 (delta 2982)
Receiving objects: 100% (5013/5013), 4.76 MiB | 7.54 MiB/s, done.
Resolving deltas: 100% (2982/2982), done.
@Songmu

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 26, 2019

Since this "meta go-import" is a Go-specific specification, there is a concern about being tightly coupled to it.

However, since go get will no longer clone the source in GOPATH after go1.13, it is inconvenient for those who used ghq to access sources, so I make ghq to be possible to clone it.

I want to merge it because it is useful for Go programmers.

@Songmu Songmu changed the title support `meta name="go-import"` to detect repository support `meta name="go-import"` to detect Go repository Apr 26, 2019

@Songmu Songmu merged commit 7866384 into motemen:master Apr 26, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Songmu Songmu deleted the Songmu:go-imports branch Apr 26, 2019

Songmu added a commit that referenced this pull request Apr 27, 2019

Checking in changes prior to tagging of version v0.10.0
## [v0.10.0](v0.9.0...v0.10.0) (2019-04-27)

* drop mitchellh/go-homedir dependency [#122](#122) ([Songmu](https://github.com/Songmu))
* introduce Go Modules and adjust releng files [#121](#121) ([Songmu](https://github.com/Songmu))
* Add a dummy CVS backend to recognize and skip CVS working directories [#115](#115) ([knu](https://github.com/knu))
* add -l option on get command which immediately look after get [#112](#112) ([kuboon](https://github.com/kuboon))
* add support for Fossil SCM [#98](#98) ([motemen](https://github.com/motemen))
* Use parsed username also with ssh for Git [#101](#101) ([jjv](https://github.com/jjv))
* Add ghq.completeUser config to disable user completion of `ghq get` [#118](#118) ([k0kubun](https://github.com/k0kubun))
* ghq get --vcs=<vcs> [#72](#72) ([motemen](https://github.com/motemen))
* warn if executable was not found when RunCommand [#70](#70) ([motemen](https://github.com/motemen))
* support `meta name="go-import"` to detect Go repository [#120](#120) ([Songmu](https://github.com/Songmu))
* support refs which start with URL Authority in ghq get [#119](#119) ([Songmu](https://github.com/Songmu))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.