Add ghq.completeUser config to disable user completion of ghq get
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually I also liked the previous behavior, but it is only a matter of preference, so I think it is a good solution to make it configurable. |
Songmu
added a commit
that referenced
this pull request
Apr 27, 2019
## [v0.10.0](v0.9.0...v0.10.0) (2019-04-27) * drop mitchellh/go-homedir dependency [#122](#122) ([Songmu](https://github.com/Songmu)) * introduce Go Modules and adjust releng files [#121](#121) ([Songmu](https://github.com/Songmu)) * Add a dummy CVS backend to recognize and skip CVS working directories [#115](#115) ([knu](https://github.com/knu)) * add -l option on get command which immediately look after get [#112](#112) ([kuboon](https://github.com/kuboon)) * add support for Fossil SCM [#98](#98) ([motemen](https://github.com/motemen)) * Use parsed username also with ssh for Git [#101](#101) ([jjv](https://github.com/jjv)) * Add ghq.completeUser config to disable user completion of `ghq get` [#118](#118) ([k0kubun](https://github.com/k0kubun)) * ghq get --vcs=<vcs> [#72](#72) ([motemen](https://github.com/motemen)) * warn if executable was not found when RunCommand [#70](#70) ([motemen](https://github.com/motemen)) * support `meta name="go-import"` to detect Go repository [#120](#120) ([Songmu](https://github.com/Songmu)) * support refs which start with URL Authority in ghq get [#119](#119) ([Songmu](https://github.com/Songmu))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Prior to v0.8.0 #81, I had used
ghq get repoto clonerepo/repo. The behavior was convenient for cloning some repositories like git/git, ruby/ruby, rails/rails, peco/peco, vim/vim, haml/haml, bundler/bundler, rack/rack, etc., as described in #14.I'd like to use the feature again because I usually clone all of my repositories at once and rarely clone my repository with
ghq get. Also I often get confused by trying to use the old behavior, even after 2 years.Solution
I'd like to introduce a git config to resurrect the original behavior:
With this config,
ghq get repoclones repo/repo. By default it's considered astrueand this PR is backward-compatible.Note that
completeuser = falsealso works by the nature ofgit config.