[fix] Make sure the directory exists with the exact name #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `os.Stat("CVS")` successfully picks `cvs` on a case insensitive
filesystem, we need to iterate through directory entries to see if a
directory with the exact name exists.
cf. x-motemen#115 (comment)
|
Alternatively, you could check for the existence of a file |
|
Indeed, "CVS" has the possibility of conflicting with a regular directory name because no dots or underscores are there. However, I do not want to reduce the overall performance for only CVS, |
|
I've fixed it by myself so I merge it now. |
|
After all, I check only the existence of CVS/Repository at #154. |
Songmu
changed the title
Songmu
added a commit
that referenced
this pull request
May 5, 2019
## [v0.11.1](v0.11.0...v0.11.1) (2019-05-05) * [feature] List vcs option [#155](#155) ([msh5](https://github.com/msh5)) * [testing] add TestDoImport [#156](#156) ([Songmu](https://github.com/Songmu)) * [fix] fix findVCSBackend and add tests [#154](#154) ([Songmu](https://github.com/Songmu)) * [fix] Make sure the directory exists with the exact name [#145](#145) ([knu](https://github.com/knu)) * [bugfix] Fix fossil support [#153](#153) ([Songmu](https://github.com/Songmu)) * [testing] add TestDoList_query [#152](#152) ([Songmu](https://github.com/Songmu)) * [testing] add TestRunInDirSilently [#151](#151) ([Songmu](https://github.com/Songmu)) * [testing] add more tests in TestDoLook [#150](#150) ([Songmu](https://github.com/Songmu)) * [testing] add TestDoLook [#149](#149) ([Songmu](https://github.com/Songmu)) * [refactoring] remove NewFakeRunner which not used [#148](#148) ([Songmu](https://github.com/Songmu)) * [refactoring] Commonize doGet and doImport processing for refactoring [#147](#147) ([Songmu](https://github.com/Songmu)) * [testing] add test for `ghq root` [#146](#146) ([Songmu](https://github.com/Songmu))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
os.Stat("CVS")successfully pickscvson a case insensitive filesystem, we need to iterate through directory entries to see if a directory with the exact name exists.cf. #115 (comment)
This certainly has an impact on performance, so any input is welcome.