Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Bluemix DevOps Git service #56

Merged
merged 1 commit into from
Jul 24, 2015

Conversation

uetchy
Copy link
Contributor

@uetchy uetchy commented Jul 9, 2015

Thank you for making great tool!
I created support for Bluemix DevOps service.
Bluemix only supporting HTTPS so we need to show prompt.

@motemen
Copy link
Member

motemen commented Jul 17, 2015

Thanks! Built-in support for hub.jazz.net seems good, as seeing go get also supports it.

But why we have to GIT_TERMINAL_PROMPT to 1? I don't get the point why we'll need to do it.

@uetchy
Copy link
Contributor Author

uetchy commented Jul 18, 2015

Unfortunately, Bluemix is only available on HTTPS so we need to show prompt for username and password to authentication. But there is chance of be suppressed to ask users with GIT_TERMINAL_PROMPT=0. Actually in my situation, prompting any messages was disabled by this env var. To assure to ask users, we need to set GIT_TERMINAL_PROMPT to 1 (I know this is not the best idea).

@motemen
Copy link
Member

motemen commented Jul 21, 2015

Thank you, I see.

But as the default value of GIT_TERMINAL_PROMPT is nonzero, the user should have set it to zero somewhere. So as a thin wrapper of git, I don't think ghq has to support this environment variable, rather it's the user's responsibility to set the environment variable to nonzero. How about that?

@uetchy
Copy link
Contributor Author

uetchy commented Jul 22, 2015

Yeah I changed the mind; there are splittable problem. I removed all changes to vcs.go first.
I will send PR later If I can fix the prompting problem.
Can you merge them?

@motemen
Copy link
Member

motemen commented Jul 24, 2015

LGTM, thanks!

motemen added a commit that referenced this pull request Jul 24, 2015
Support for Bluemix DevOps Git service
@motemen motemen merged commit 3351bd5 into x-motemen:master Jul 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants