Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pathcorrect doesn't merge coverage #4

Closed
psychon opened this issue Feb 7, 2016 · 3 comments
Closed

Pathcorrect doesn't merge coverage #4

psychon opened this issue Feb 7, 2016 · 3 comments

Comments

@psychon
Copy link

psychon commented Feb 7, 2016

Hi,

I'm in the process of adding coverage testing to awesome. Thanks for writing this code!
However, due to $REASONS there are two kind of tests in awesome. One of them runs through busted and ends up with absolute paths to the Lua source files while the other one has relative paths. With pathcorrect the paths end up correctly in the end, but LuaCov/Coveralls still counts these as two different files.

For an example look at https://coveralls.io/jobs/11825631 and search for files with "sort" in their name. Two instances of lib/gears/sort.lua will be found and they have different coverage.

Is there a sane way to have these duplicate files merged?

Thanks!

@moteus
Copy link
Owner

moteus commented Feb 8, 2016

Can you test current master please.

@psychon
Copy link
Author

psychon commented Feb 8, 2016

@psychon psychon closed this as completed Feb 8, 2016
@moteus
Copy link
Owner

moteus commented Feb 10, 2016

Just release new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants