Fixed delete confirmation showing as translation key #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeholdcroft
added a commit
that referenced
this pull request
Jun 24, 2014
…n-fix Fixed delete confirmation showing as translation key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Fixes #66 by correcting the translation key.
How should this be manually tested?
Go to file manager, try to delete a file, see whether the confirmation text is a translation key or actual words that make sense.
Looked like this before (see issue description for details):
https://www.dropbox.com/s/znzc1om1x8bu6kw/Screenshot%202014-06-11%2016.04.11.png
Should look like this now:
Related PRs / Issues / Resources?
Issue: #66
Anything else to add? (Screenshots, background context, etc)