change link to /terms

[aislingbrock]

What does this do?

Turns that horrible returns link that always leads to nowhere from whatever it was to /terms. Just make your terms page slug /terms and VOILA! No more pesky QA point every time anyone makes a website.

How should this be manually tested?

Related PRs / Issues / Resources?

Anything else to add? (Screenshots, background context, etc)

[kuiche]

Not sure if hardcoding this link is the best way of "fixing" this issue. If we do it this way, we should deprecate the functionality in the returns module too.

@thomasjthomasj thoughts? Should users be using the terms and conditions route provided by the module? Or should we assume that users will use '/terms' (in which case should mothership have a route)? Should it be smarter?

I personally feel like the terms and conditions page should be in the CMS (so not using the route provided by returns) but that it should load in the page in a better way and find the slug based on the page, rather than assuming the slug will be '/terms'.

[aislingbrock]

yeah, IDK, I think the current way was meant to be "smart" and obviously it was a steaming pile of crap :D

[thomasjthomasj]

Hmm... it would be nice to have a smarter way of dealing with it but I can't see any way to do that at the moment. I think this fix is fine for now, it's the skeleton theme so people are expected to change it where they feel appropriate. That said, I think 'terms-and-conditions' makes more sense than just 'terms'

[aislingbrock]

I hath changed it to terms-and-conditions