feat(2d): make Code not experimental (#1000)

motion-canvas · Mar 20, 2024 · aa871a1 · aa871a1
1 parent c6db8ce
commit aa871a1
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 5 deletions.
diff --git a/packages/2d/src/lib/components/Code.ts b/packages/2d/src/lib/components/Code.ts
@@ -1,7 +1,7 @@
 import {
   BBox,
   createSignal,
-  ExperimentalError,
+  experimentalLog,
   lazy,
   map,
   SerializedVector2,
@@ -11,6 +11,8 @@ import {
   ThreadGenerator,
   TimingFunction,
   unwrap,
+  useLogger,
+  useScene,
   Vector2,
 } from '@motion-canvas/core';
 import {
@@ -35,7 +37,6 @@ import {
 } from '../code';
 import {computed, initial, nodeName, parser, signal} from '../decorators';
 import {DesiredLength} from '../partials';
-import {useScene2D} from '../scenes';
 import {Shape, ShapeProps} from './Shape';
 
 /**
@@ -249,6 +250,20 @@ export class Code extends Shape {
   @signal()
   public declare readonly drawHooks: SimpleSignal<DrawHooks, this>;
 
+  protected setDrawHooks(value: DrawHooks) {
+    if (
+      !useScene().experimentalFeatures &&
+      value !== this.drawHooks.context.getInitial()
+    ) {
+      useLogger().log({
+        ...experimentalLog(`Code uses experimental draw hooks.`),
+        inspect: this.key,
+      });
+    } else {
+      this.drawHooks.context.setter(value);
+    }
+  }
+
   /**
    * The currently selected code range.
    *
@@ -331,9 +346,6 @@ export class Code extends Shape {
       fontFamily: 'monospace',
       ...props,
     });
-    if (!useScene2D().experimentalFeatures) {
-      throw new ExperimentalError('The Code node is an experimental feature');
-    }
   }
 
   /**

diff --git a/packages/2d/src/lib/components/CodeBlock.ts b/packages/2d/src/lib/components/CodeBlock.ts
@@ -47,6 +47,9 @@ export interface CodeModification {
   to: Code;
 }
 
+/**
+ * @deprecated Use {@link Code} instead.
+ */
 @nodeName('CodeBlock')
 export class CodeBlock extends Shape {
   private static initialized = createComputedAsync(