Skip to content

Commit

Permalink
fix(2d): fix transition scaling (#1017)
Browse files Browse the repository at this point in the history
  • Loading branch information
aarthificial committed Mar 30, 2024
1 parent 5bd7c8e commit bccf8a9
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion packages/core/src/transitions/slideTransition.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export function* slideTransition(
direction: Direction | Origin = Direction.Top,
duration = 0.6,
): ThreadGenerator {
const size = useScene().getSize();
const size = useScene().getRealSize();
const position = size.getOriginOffset(direction).scale(2);
const previousPosition = Vector2.createSignal();
const currentPosition = Vector2.createSignal(position);
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/transitions/zoomInTransition.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {useTransition} from './useTransition';
* @param duration - The duration of the transition.
*/
export function* zoomInTransition(area: BBox, duration = 0.6): ThreadGenerator {
const scale = useScene().getSize().div(area.size);
const scale = useScene().getRealSize().div(area.size);

const currentPosition = Vector2.createSignal(area.position);
const currentScale = Vector2.createSignal(Vector2.one.div(scale));
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/transitions/zoomOutTransition.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export function* zoomOutTransition(
area: BBox,
duration = 0.6,
): ThreadGenerator {
const scale = useScene().getSize().div(area.size);
const scale = useScene().getRealSize().div(area.size);

const currentPosition = Vector2.createSignal(
area.position.flipped.mul(scale),
Expand Down
2 changes: 1 addition & 1 deletion packages/docs/docs/getting-started/transitions.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export function* slideTransition(
direction: Direction = Direction.Top,
duration = 0.6,
): ThreadGenerator {
const size = useScene().getSize();
const size = useScene().getRealSize();
const position = size.getOriginOffset(direction).scale(2);
const previousPosition = Vector2.createSignal();
const currentPosition = Vector2.createSignal(position);
Expand Down

0 comments on commit bccf8a9

Please sign in to comment.