Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor locks up when setting the FPS to a negative value #936

Closed
SecondFlight opened this issue Feb 5, 2024 · 1 comment · Fixed by #937
Closed

Editor locks up when setting the FPS to a negative value #936

SecondFlight opened this issue Feb 5, 2024 · 1 comment · Fixed by #937
Assignees
@aarthificial
Labels
b-bug Something isn't working c-accepted The issue is ready to be worked on

Comments

@SecondFlight
Copy link

SecondFlight commented Feb 5, 2024 •
edited

Describe the bug
Setting the preview FPS to a negative value causes the editor to lock up.

To reproduce

  1. Create a new project
  2. Open the editor
  3. Set the preview FPS to a negative value

Expected behavior
The editor should correct or ignore the user's setting, but should not lock up.

Package versions:

  • core: 3.14.0
  • two: 3.14.0
  • ui: 3.14.0
  • vitePlugin: 3.14.0

Additional context:
Thanks for creating this project! I'm a first-time user and was exploring the UI. The preview FPS input can be changed with click & drag, and while changing it I accidentally set it to -6, causing the editor to lock up.

For anyone else with this issue, it can be fixed by editing src/project.meta and changing 'preview' -> 'fps' to a positive number.
@SecondFlight SecondFlight added the b-bug Something isn't working label Feb 5, 2024
aarthificial added a commit to aarthificial/motion-canvas that referenced this issue Feb 6, 2024
@aarthificial
fix: limit fps to positive numbers
e199add 
Closes: motion-canvas#936
@aarthificial aarthificial mentioned this issue Feb 6, 2024
Merged
@aarthificial aarthificial added the c-accepted The issue is ready to be worked on label Feb 6, 2024
aarthificial added a commit that referenced this issue Feb 6, 2024
@aarthificial
fix: limit fps to positive numbers (#937)
c7c0c67 
Closes: #936
@aarthificial
Copy link
Contributor

Thanks for the report!
It will be fixed in 3.14.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aarthificial aarthificial

Labels
b-bug Something isn't working c-accepted The issue is ready to be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: limit fps to positive numbers aarthificial/motion-canvas
2 participants
@SecondFlight @aarthificial