feat(2d, core, vite-plugin): add cors proxy and integrated into Image component #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaldemarLehner
commented
Feb 16, 2023
WaldemarLehner
commented
Feb 16, 2023
exdeejay
suggested changes
Feb 16, 2023
packages/core/src/utils/viaProxy.ts
Outdated
| } | ||
| } catch (_) { | ||
| // in case of error just silently pass as-is | ||
| return url; |
There was a problem hiding this comment.
IMO a malformed or non-HTTP(S) URL should have an associated warning that the URL isn't being proxied, but maybe that's too verbose.
There was a problem hiding this comment.
i think that the Browser can do that for us — if it is indeed bad value.
Maybe there is some non-standard way of providing a resource that URL does not handle — in this case, the value should probably not be proxied anyways.
If the Browser cannot understand the passed value it will log to the console, if it can, it will interpret it correctly.
|
Possible idea: in Image.ts, check if the proxy is disabled and if so, set |
aarthificial
requested changes
Feb 18, 2023
WaldemarLehner
force-pushed
the
feat-338
branch
3 times, most recently
from
b077914
to
4ca5730
Compare
aarthificial
requested changes
Feb 20, 2023
fix(vite-plugin): fix remote sources breaking Rendering by implementing proxy(motion-canvas#338) feat(core): add viaProxy Utility to rewrite requests to proxy (motion-canvas#338) Apply proposed changes Co-authored-by: Jacob <64662184+aarthificial@users.noreply.github.com>
WaldemarLehner
force-pushed
the
feat-338
branch
from
4ca5730
to
3686810
Compare
aarthificial
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR touches the following packages:
vite-plugin
Adds a new
proxy-middleware.tswhich defines a Middleware which proxies GET-Requests using the/cors-proxyEndpoint — this is the "main" part of this PRAlso adds a new virtual module,
virtual:proxysettings, which returns{enabled: boolean}.This is used by the changes in core. This value is either true or false depending on if the user has disabled to proxy by setting
proxy:falseas an option of the vite plugin.core
Adds a new util,
viaProxy.Anything that might touch a remote resource can use this helper to proxy the request.
The idea behind
viaProxyis that it will only rewrite if a resource is rewritable.virtual:proxysettings)httpandhttpsto not break inlinedata:sourceshost2d
A small change has been made to the
<Image/>component.The computed prop
imagewraps thesrcsignal intowithProxy.Closes #338
Closes #234
Relevant Discord Thread: https://discord.com/channels/1071029581009657896/1076868990573477998