feat(2d): add line counter for CodeBlock#802
Merged
aarthificial merged 1 commit intoSep 17, 2023
Merged
Conversation
aarthificial
requested changes
Sep 9, 2023
Contributor
This happens because during tweening, a temporary structure stored in
|
3ffd1ea to
cbb24cb
Compare
Contributor
Author
|
@aarthificial I applied your suggestions and looks good in my opinion. |
aarthificial
requested changes
Sep 17, 2023
aarthificial
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Needs just two little fixes
cbb24cb to
4da801d
Compare
aarthificial
approved these changes
Sep 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I think it would be useful to add a feature that allows for retrieving the current count of CodeBlock's lines.
e.g. I'm using this for my custom 'CodeEditor' component that has numbering on the left side.
BTW: When getting this value it has some delay. It could be probably improved in some way, but I'm not sure how.