feat(core): allow ordering of scenes during transition #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarthificial
requested changes
Oct 24, 2023
rmhartog
force-pushed
the
dynamic-scene-order-transition
branch
from
a73c623
to
466a8e3
Compare
|
@aarthificial I've updated the PR based on your comments. Could you take another look? 🙂 |
aarthificial
approved these changes
Oct 25, 2023
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a third argument to
useTransition, which is a boolean or signal indicating whether the previous scene is rendered on top of the current scene during the transition.Solves #369.