Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

934 slanted fonts fix #968

Merged
merged 2 commits into from Mar 1, 2024

Conversation

CactusPuppy
Copy link
Contributor

This PR attempts to fix #934 by expanding the BBox returned by getCacheBBox for TxtLeaf by half of the element's font size horizontally.

packages/2d/src/lib/components/TxtLeaf.ts Outdated Show resolved Hide resolved
packages/2d/src/lib/components/TxtLeaf.ts Outdated Show resolved Hide resolved
@aarthificial
Copy link
Contributor

Thanks for the fix!
I left a comment regarding line validation in #969

@aarthificial aarthificial merged commit abb0906 into motion-canvas:main Mar 1, 2024
9 checks passed
@CactusPuppy CactusPuppy deleted the 934-slanted-fonts-fix branch March 1, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants