Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Python3 support #1572

Closed
wants to merge 0 commits into from
Closed

[WIP] Python3 support #1572

wants to merge 0 commits into from

Conversation

ccrisan
Copy link
Collaborator

@ccrisan ccrisan commented Dec 15, 2019

No description provided.

This was referenced Dec 15, 2019
Closed
Closed
cclauss added a commit to cclauss/motioneye that referenced this pull request Jan 2, 2020
@cclauss
Travis CI: Use flake8 to find Python 3 compatibility issues
96e024c 
Tests related to motioneye-project#1572
@cclauss cclauss mentioned this pull request Jan 2, 2020
Merged
@cclauss
Copy link
Member

cclauss commented Jan 2, 2020

Perhaps add these Travis CI changes as a quick double check:
https://github.com/ccrisan/motioneye/pull/1589/files

This was referenced Feb 10, 2020
Closed
Closed
cclauss
cclauss reviewed Feb 22, 2020
View reviewed changes
motioneye/utils.py Outdated Show resolved Hide resolved
@cclauss
Copy link
Member

cclauss commented Dec 29, 2020

Three files with conflicts that must be resolved.

@STrRedWolf STrRedWolf mentioned this pull request Feb 10, 2021
Closed
@mgrouch mgrouch mentioned this pull request Feb 23, 2021
Closed
@MichaIng
Copy link
Member

MichaIng commented Mar 8, 2022

Conflicts resolved.

@marcopaganini
In 6a9e709 you changed it so that pip is left installed in the Docker image. Was this intended, i.e. is pip required for something or was it was forgotten? I added it back in for being purged when resolving conflicts, but can be reverted.

@MichaIng MichaIng added the python update python 2 > python 3 label Mar 8, 2022
@MichaIng MichaIng mentioned this pull request Mar 8, 2022
Open
4 tasks
@MichaIng
Copy link
Member

MichaIng commented Mar 8, 2022

Approving, so we can continue with rebasing and merging other Python 3 related PRs and can start testing on the dev branch then.

@MichaIng MichaIng mentioned this pull request Mar 8, 2022
Merged
@MichaIng MichaIng closed this Mar 9, 2022
@MichaIng
Copy link
Member

MichaIng commented Mar 9, 2022

No worries, it got merged indirectly via #2313, so we are on track.

@MichaIng MichaIng deleted the python3 branch March 9, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss left review comments

@MichaIng MichaIng MichaIng approved these changes

@jmichault jmichault Awaiting requested review from jmichault

Assignees
No one assigned
Labels
python update python 2 > python 3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ccrisan @cclauss @MichaIng