Add tests for Modal component #171
Conversation
|
Thanx man! I’ll check a bit later today 😉 |
| <div className={b('inner')}> | ||
| <div className={b('title')}> | ||
| <div className={b('inner')()}> | ||
| <div className={b('title')()}> |
|
@s4nji looks solid 👍 |
|
|
||
| import Modal from '../../../components/Modal/Modal'; | ||
|
|
||
| configure({ adapter: new Adapter() }); |
There was a problem hiding this comment.
This configure statement should be inside of a setup file like this one:
https://github.com/hellofresh/my-deliveries-fragment/blob/master/__tests__/setup.js
Also, take a look at this file:
https://github.com/hellofresh/my-deliveries-fragment/blob/master/.jestrc#L2-L5
It contains the instructions to provide a setup file.
| }; | ||
| const runCommonTest = (wrapper, props) => { | ||
| const tree = toJSON(wrapper); | ||
| const modaliz = tree.children[0]; |
There was a problem hiding this comment.
const [ modaliz ] = tree.children;| configure({ adapter: new Adapter() }); | ||
|
|
||
| describe('Modal component', () => { | ||
| const render = props => mount(<Modal {...props} />); |
There was a problem hiding this comment.
You can probably pass the requiredProps directly in this render function, so you don't have to the following over and over again:
const props = {
...requiredProps,
title: 'Modal test title',
};There was a problem hiding this comment.
We will also need to pass it again in runCommonTest if we pass it on the render function
I think redefining the props on every test makes it easier to debug since you don't need to search around to find the contents of props 🙂
s4nji
force-pushed
the
feature/add-modal-tests
branch
from
277f8ae
to
eecd7c5
Compare
s4nji
force-pushed
the
feature/add-modal-tests
branch
from
eecd7c5
to
0211f0c
Compare
|
+1 Really well done! |
Adds tests for Modal component