Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PUT when updating OAuth Server Item #216

Merged
merged 4 commits into from
Nov 20, 2017
Merged

Use PUT when updating OAuth Server Item #216

merged 4 commits into from
Nov 20, 2017

Conversation

s4nji
Copy link
Contributor

@s4nji s4nji commented Nov 17, 2017

No description provided.

@@ -19,5 +20,6 @@ export default connect(
fetchOAuthServer,
fetchOAuthServerSchema,
saveOAuthServer,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz remove this as far as we don't use it anymore

@@ -4,6 +4,7 @@ import {
fetchOAuthServer,
fetchOAuthServerSchema,
saveOAuthServer,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz remove this as far as we don't use it anymore

@ivanzusko
Copy link
Contributor

Awesome, @s4nji !
As an improvement, we can also change isFetching while saving or updating, just in case if it will take some time to proceed...

@s4nji
Copy link
Contributor Author

s4nji commented Nov 20, 2017

@ivanzusko @rafaeljesus Updated, please re-check 🙂

Copy link
Contributor

@ivanzusko ivanzusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@s4nji s4nji merged commit 7465f40 into master Nov 20, 2017
@s4nji s4nji deleted the fix/update-oauth branch November 20, 2017 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants