Display logged user #57
Conversation
src/helpers/parseJwt.js
Outdated
| @@ -0,0 +1,6 @@ | |||
| export const parseJwt = token => { | |||
| const base64Url = token.split('.')[1]; | |||
There was a problem hiding this comment.
Please use a library to parse JWT. Maybe this one https://github.com/auth0/node-jsonwebtoken
There was a problem hiding this comment.
Done, @italolelis
src/modules/Layout/Header/Header.js
Outdated
| @@ -7,7 +8,12 @@ import './Header.css'; | |||
|
|
|||
| const b = block('j-header'); | |||
|
|
|||
| const Header = ({ logged }) => { | |||
| const propTypes = { | |||
| logged: PropTypes.bool.isRequired, | |||
There was a problem hiding this comment.
if you already have the user wouldn't that already imply that it is logged in?
There was a problem hiding this comment.
actually yes, @Vxplus , totally agree!
src/modules/Layout/Header/Header.js
Outdated
| @@ -18,6 +24,12 @@ const Header = ({ logged }) => { | |||
| <Nav /> | |||
| </div> | |||
| <div className={b('col', { right: true })}> | |||
| { | |||
| user && | |||
| <span className={b('user')}> | |||
There was a problem hiding this comment.
maybe user-name or display-name would be more specific for this user sounds like a container imo.
src/modules/Layout/Header/Header.js
Outdated
| const Header = ({ logged }) => { | ||
| const propTypes = { | ||
| logged: PropTypes.bool.isRequired, | ||
| user: PropTypes.string.isRequired, |
There was a problem hiding this comment.
maybe username fits this more.
There was a problem hiding this comment.
maybe in future, there will appear some additional info, so I will change user<String> to user<Object> and fill it with all necessary info. What do you think, @Vxplus ?
No description provided.