EES-574 Support dynamic port for deps in integration tests #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgarvardt
force-pushed
the
patch/tests-dynamic-port
branch
from
94a8032
to
edbbfa1
Compare
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
=======================================
Coverage 40.46% 40.46%
=======================================
Files 76 76
Lines 2659 2659
=======================================
Hits 1076 1076
Misses 1520 1520
Partials 63 63 Continue to review full report at Codecov.
|
|
+1
|
RTodorov
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it is not being used as travis allows static ports binding, but in GH Actions port is going to be dynamic, so it will be passed as env var to tests.
This PR adds dynamic port support to integration tests only, feature tests to be done.
One test marked as integration is simple unit test actually that does not require any deps, so build tag was removed.