Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:[HL-81]Single Random Meal API #92

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Conversation

esraakhaled
Copy link
Contributor

@esraakhaled esraakhaled commented Jul 12, 2023

1.create Model for Entity
2.create RandomMealRequest model
3.Create RandomMealRequestTests

Screenshot

N/A

Checklist

  • I have tested these changes locally.
  • I have added appropriate documentation or updated existing documentation.
  • I have added appropriate test coverage or updated existing test coverage.
  • I have updated the changelog (if applicable).
  • I have followed the project's code style and formatting guidelines.
  • I have reviewed and adhered to the project's contributing guidelines.

1.create Model for Entity
2.create RandomMealRequest model
3.Create RandomMealRequestTests
Comment on lines 5 to 11
let idMeal: String
let strMeal: String
let strCategory: String
let strArea: String
let strMealThumb: String
let strTags: String
let strYoutube: String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rewrite the names to be more descriptive.

Comment on lines 10 to 16
let idMeal: String
let strMeal: String
let strCategory: String
let strArea: String
let strMealThumb: String
let strTags: String
let strYoutube: String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Names should be descriptive as well


// MARK: - RandomMealsResponse
public struct RandomMealsResponse: Codable {
let meals: [RandomMeal]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let meals: [RandomMeal]
public let meals: [RandomMeal]

Comment on lines 10 to 16
let idMeal: String
let strMeal: String
let strCategory: String
let strArea: String
let strMealThumb: String
let strTags: String
let strYoutube: String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let idMeal: String
let strMeal: String
let strCategory: String
let strArea: String
let strMealThumb: String
let strTags: String
let strYoutube: String
public let idMeal: String
public let strMeal: String
public let strCategory: String
public let strArea: String
public let strMealThumb: String
public let strTags: String
public let strYoutube: String

let strTags: String
let strYoutube: String

enum CodingKeys: String, CodingKey {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
enum CodingKeys: String, CodingKey {
private enum CodingKeys: String, CodingKey {

Comment on lines 37 to 38
public var method: String { "GET" }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public var method: String { "GET" }
public var method: String { "GET" }

@esraakhaled esraakhaled merged commit deb0d27 into develop Jul 13, 2023
2 checks passed
@esraakhaled esraakhaled deleted the feat/single-random-meal-API branch July 13, 2023 21:20
@esraakhaled esraakhaled mentioned this pull request Jul 14, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants