-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:[HL-81]Single Random Meal API #92
Conversation
1.create Model for Entity 2.create RandomMealRequest model 3.Create RandomMealRequestTests
let idMeal: String | ||
let strMeal: String | ||
let strCategory: String | ||
let strArea: String | ||
let strMealThumb: String | ||
let strTags: String | ||
let strYoutube: String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rewrite the names to be more descriptive.
let idMeal: String | ||
let strMeal: String | ||
let strCategory: String | ||
let strArea: String | ||
let strMealThumb: String | ||
let strTags: String | ||
let strYoutube: String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Names should be descriptive as well
|
||
// MARK: - RandomMealsResponse | ||
public struct RandomMealsResponse: Codable { | ||
let meals: [RandomMeal] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let meals: [RandomMeal] | |
public let meals: [RandomMeal] |
let idMeal: String | ||
let strMeal: String | ||
let strCategory: String | ||
let strArea: String | ||
let strMealThumb: String | ||
let strTags: String | ||
let strYoutube: String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let idMeal: String | |
let strMeal: String | |
let strCategory: String | |
let strArea: String | |
let strMealThumb: String | |
let strTags: String | |
let strYoutube: String | |
public let idMeal: String | |
public let strMeal: String | |
public let strCategory: String | |
public let strArea: String | |
public let strMealThumb: String | |
public let strTags: String | |
public let strYoutube: String |
let strTags: String | ||
let strYoutube: String | ||
|
||
enum CodingKeys: String, CodingKey { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enum CodingKeys: String, CodingKey { | |
private enum CodingKeys: String, CodingKey { |
public var method: String { "GET" } | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public var method: String { "GET" } | |
public var method: String { "GET" } |
1.create Model for Entity
2.create RandomMealRequest model
3.Create RandomMealRequestTests
Screenshot
N/A
Checklist