ci: improve setting ENV in CI

Signed-off-by: Rong Sen Ng (motss) <wes.ngrongsen@gmail.com>
motss · Mar 9, 2022 · 46a4848 · 46a4848
1 parent 97a058d
commit 46a4848
Show file tree

Hide file tree

Showing 6 changed files with 26 additions and 5 deletions.
diff --git a/.changeset/cyan-taxis-marry.md b/.changeset/cyan-taxis-marry.md
@@ -0,0 +1,5 @@
+---
+"app-datepicker": patch
+---
+
+ci: improve setting ENV in CI
diff --git a/.changeset/funny-camels-dream.md b/.changeset/funny-camels-dream.md
@@ -0,0 +1,5 @@
+---
+"app-datepicker": patch
+---
+
+ci: trying to improve CI
diff --git a/.changeset/fuzzy-buckets-heal.md b/.changeset/fuzzy-buckets-heal.md
@@ -0,0 +1,5 @@
+---
+"app-datepicker": patch
+---
+
+chore: update dependencies
diff --git a/.changeset/honest-eels-shop.md b/.changeset/honest-eels-shop.md
@@ -0,0 +1,5 @@
+---
+"app-datepicker": patch
+---
+
+fix: fix stylings not using the correct CSS variables
diff --git a/.github/workflows/ci-helpers.yml b/.github/workflows/ci-helpers.yml
@@ -18,6 +18,7 @@ defaults:
 
 env:
   CI_SKIP: false
+  COVERAGE: false
   GITHUB_COMMIT_MESSAGE: ''
   IS_UBUNTU: false
   NODE_VERSION: v0.0.0
@@ -99,16 +100,14 @@ jobs:
       - name: Test
         if: env.CI_SKIP == 'false' && env.IS_UBUNTU == 'false'
         run: |
-          export TEST_HELPERS=true
           npm run wtr
 
       - name: Test with coverage
         if: env.CI_SKIP == 'false' && env.IS_UBUNTU != 'false'
         run: |
-          printf "%s" "$TEST_HELPERS"
-          export COVERAGE=true
-          export TEST_HELPERS=true
           npm run wtr
+        env:
+          COVERAGE: true
 
       - name: Upload coverage to codecov
         if: env.CI_SKIP == 'false' && env.IS_UBUNTU != 'false' && success()

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -18,6 +18,7 @@ defaults:
 
 env:
   CI_SKIP: false
+  COVERAGE: false
   GITHUB_COMMIT_MESSAGE: ''
   IS_UBUNTU: false
   NODE_VERSION: v0.0.0
@@ -111,8 +112,9 @@ jobs:
       - name: Test with coverage
         if: env.CI_SKIP == 'false' && env.IS_UBUNTU != 'false'
         run: |
-          export COVERAGE=true
           npm run wtr
+        env:
+          COVERAGE: true
 
       - name: Upload coverage to codecov
         if: env.CI_SKIP == 'false' && env.IS_UBUNTU != 'false' && success()