Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On the meaning and the behavior of swipeLeft and swipeRight properties #4

Open
leodido opened this issue Jul 19, 2016 · 0 comments
Open

Comments

@leodido
Copy link

leodido commented Jul 19, 2016

Currently <paper-swipe> has two properties, i.e. swipeLeft and swipeRight.

Their semantic communicates that when one of the two is true, the swiping in its opposite direction should be disallowed.
E.g., When swipeLeft is true <paper-swipe> should only allow swiping to left.

But currently their actual behavior is not what I would expect. Indeed the swiping is always allowed in both directions.

So I think that this two properties, at this time, are implementing something different.

Something better understood if the properties were called leftEdge and rightEdge.

Infact they express the edge to which the swipeable container will adhere to.

I know that renaming would require a major version release but let me know what do you think about this discussion (and this names, probably better ones exist too). I'm available to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants