You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently <paper-swipe> has two properties, i.e. swipeLeft and swipeRight.
Their semantic communicates that when one of the two is true, the swiping in its opposite direction should be disallowed.
E.g., When swipeLeft is true <paper-swipe> should only allow swiping to left.
But currently their actual behavior is not what I would expect. Indeed the swiping is always allowed in both directions.
So I think that this two properties, at this time, are implementing something different.
Something better understood if the properties were called leftEdge and rightEdge.
Infact they express the edge to which the swipeable container will adhere to.
I know that renaming would require a major version release but let me know what do you think about this discussion (and this names, probably better ones exist too). I'm available to submit a PR.
The text was updated successfully, but these errors were encountered:
Currently
<paper-swipe>
has two properties, i.e.swipeLeft
andswipeRight
.Their semantic communicates that when one of the two is true, the swiping in its opposite direction should be disallowed.
E.g., When
swipeLeft
is true<paper-swipe>
should only allow swiping to left.But currently their actual behavior is not what I would expect. Indeed the swiping is always allowed in both directions.
So I think that this two properties, at this time, are implementing something different.
Something better understood if the properties were called
leftEdge
andrightEdge
.Infact they express the edge to which the swipeable container will adhere to.
I know that renaming would require a major version release but let me know what do you think about this discussion (and this names, probably better ones exist too). I'm available to submit a PR.
The text was updated successfully, but these errors were encountered: