Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse-in-comment always starts collapsed #12

Open
aspiers opened this issue Oct 2, 2016 · 11 comments
Open

Collapse-in-comment always starts collapsed #12

aspiers opened this issue Oct 2, 2016 · 11 comments

Comments

@aspiers
Copy link

aspiers commented Oct 2, 2016

Even if Start with blocks collapsed? is set to false, the blocks are still automatically collapsed when an issue loads.

@Mottie
Copy link
Owner

Mottie commented Oct 2, 2016

Hi @aspiers!

Make sure to reload the page (Shift + F5) after changing the option as the script is loaded into the page and does not refresh because GitHub uses ajax page loading.


I just update the documentation to emphasize this necessity.

@aspiers
Copy link
Author

aspiers commented Oct 3, 2016

false appears to be the default value (at least it was for me), so this is a problem even without changing the option. I also tried changing to true and reloading and the behaviour didn't change.

@Mottie
Copy link
Owner

Mottie commented Oct 3, 2016

The setting will always initially show the opposite of the current setting - see line 233.

LOL, actually, I just tested it and it does toggle the areas even without a page reload.

Maybe there is another script interfering? Are you using Octopatcher?

@aspiers
Copy link
Author

aspiers commented Oct 3, 2016

Oh, I see! So when I typed in true, I wasn't actually changing it at all :-)

Hmm, this is not an intuitive UI at all. Perhaps you can think of some way to make it clearer, e.g. tweaking the text?

@aspiers
Copy link
Author

aspiers commented Oct 3, 2016

To be clear, it does work now I understand how it's supposed to work :-)

@Mottie
Copy link
Owner

Mottie commented Oct 3, 2016

What would you suggest?

@Mottie
Copy link
Owner

Mottie commented Oct 3, 2016

In Octopatcher (an addon created from this userscript), I set a select with two options: collapsed & expanded. Does that make more sense?

Also, I'm going out of town on the 4th, I'll be unavailable for a month, or so. So please don't think I'm ignoring you if I don't respond.

@aspiers
Copy link
Author

aspiers commented Oct 3, 2016

That sounds better but I'd have to see it to be sure.

@Mottie
Copy link
Owner

Mottie commented Oct 3, 2016

Updated.

@aspiers
Copy link
Author

aspiers commented Oct 3, 2016

Thanks - this is better for sure, but the main source of the confusion is still there, i.e. that the value auto-populated in the dialog is the opposite of the current state, so that you only have to click OK to change it. Could the text also give the current state, or clarify this somehow?

@Mottie
Copy link
Owner

Mottie commented Oct 3, 2016

Ok, the current state is now visible.

Eventually, I'd like to change out the prompt for a modal window with a select and number input similar to what I have set up for Octopatcher, but without the "Enabled" checkbox:

content-collapse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants