Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: collapse inline PR comments #30

Closed
olets opened this issue Nov 29, 2017 · 5 comments
Closed

request: collapse inline PR comments #30

olets opened this issue Nov 29, 2017 · 5 comments

Comments

@olets
Copy link

olets commented Nov 29, 2017

I'd love a toggle to collapse inline comments in the files view of a PR, with a "toggle all" button and individual toggles on each comment.

Use case: for PRs that are complicated or need a bunch of background knowledge, my team likes to sprinkle in explanatory comments to help reviewers… but that can make the PR look intimidating, and can make reviewing harder for people who don't need the explanations.

Presumably not a small project. I'd be happy to donate towards this

Thanks for all the great tools!

@Mottie
Copy link
Owner

Mottie commented Nov 29, 2017

Hi @olets!

I'm glad you're finding the scripts useful! 😸

Have you tried the issue comments userscript? It has toggles for reviews and diff comments, both current and outdated.

Or do you mean replace the ugly comment checkbox that allows you to hide individual comments when on the files tab? And maybe make Shift+Click toggle them all?

@olets
Copy link
Author

olets commented Nov 29, 2017

Oh sweet, no I didn't try it because of

It only works on issue comment pages.

Will give it a try!

@Mottie
Copy link
Owner

Mottie commented Nov 29, 2017

Oops! I've just fixed that message.

@olets
Copy link
Author

olets commented Nov 30, 2017

Ok tried it out. Yes, that does exactly what I wanted in the Conversation tab 🎉

For the Files tab, I don't think I ever noticed the Show Comments check box! How surprising. Looking at it now:

  • Yes, I'd love to be able to shift-click to toggle them all.
  • Hidden comments are completely hidden. I'd much rather have them collapsed than fully hidden. Maybe the "Show Comments" checkbox could be replaced with a "Collapse Comments" checkbox? Or Comments: Show | Collapse | Hide styled to match your diff files filter?
  • That check box only shows on files that have comments. It'd be cool to have a button at the top of the page (maybe near Unified | Split?) to set the checkbox state for every file

What do you think?

@Mottie
Copy link
Owner

Mottie commented Dec 11, 2017

All done. Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants