Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GitHub Sort Content) Add gitlab.com support for sorting markdown tables #40

Closed
haraldreingruber opened this issue Apr 7, 2018 · 9 comments

Comments

@haraldreingruber
Copy link

haraldreingruber commented Apr 7, 2018

How much effort is it to make the GitHub Sort Content script also work for gitlab.com markdown tables?

I would also consider contributing the enhancement myself. I guess once I figured out the difference compared to the github.com markdown rendering it should not be very difficult.
Just adding the @include rule is not enough, I've already tried that.

@Mottie
Copy link
Owner

Mottie commented Apr 8, 2018

Hi @haraldreingruber!

Since I haven't been using GitLab that much, I'll need your help locating more content to make sortable.

I threw together a userscript - https://gitlab.com/Mottie/GitLab-userscripts/wikis/GitLab-sort-content

Right now it'll sort the repo file list and any markdown tables. Please let me know if it ever stops working and what content would be good to add.

@haraldreingruber
Copy link
Author

haraldreingruber commented Apr 9, 2018

Thanks a lot @Mottie!
Unfortunately, the link above doesn't seem to have public access permissions.

I've created 2 test cases in the meanwhile, one for Gitlab (Wiki-)Pages, and one for Markdown files within the repo:

@Mottie
Copy link
Owner

Mottie commented Apr 9, 2018

You need to log into GitLab to see the repository for some reason... I made it public, so I'm not sure why this is the case.

@haraldreingruber
Copy link
Author

Still not visible to me, if you want you can add me with my username @harald.reingruber
If you add me as owner I can offer to have a look why the code is not public... you can revoke the role afterwards.

Thanks a lot.

@Mottie
Copy link
Owner

Mottie commented Apr 9, 2018

Done. And I just added wiki table sorting.

@haraldreingruber
Copy link
Author

haraldreingruber commented Apr 9, 2018

Thanks. I've changed the Gitlab repo, wiki, issue-tracker, etc. to public... I tested it without being logged in, and also with another user which is not a member of the project. After a first quick test it looks like write access is only for project members, or via merge-request. Will check the permissions more extensively later this evening. (I only used gitlab with private repos so far).

Let me know if my assumption about the project permissions are not what you had in mind.

@Mottie
Copy link
Owner

Mottie commented Apr 9, 2018

So weird... I'm sure I saw the setting and it was set to public. I guess I should RTFM.😸

@haraldreingruber
Copy link
Author

Yeah, there is a setting for the project itself, but then there are also the ones per feature... I think that was causing the confusion.

@haraldreingruber
Copy link
Author

haraldreingruber commented Apr 9, 2018

Cool, it works quite well. Thanks for the super fast response 😄 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants