Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GitHub Sort Reactions) Third click on 'sort by +1' and 'speak no evil monkey' avatar icons doesn't restore the comment order in some cases #42

Closed
darkred opened this issue Apr 11, 2018 · 5 comments
Labels

Comments

@darkred
Copy link
Collaborator

darkred commented Apr 11, 2018

STR
In a clean Chrome 65 profile with only Tampermonkey 4.6.5752 beta installed and GSR script v0.2.2:

case 1

open https://github.com/gorhill/uMatrix/issues/928 and click on the 'speak no evil monkey' avatar sort icon 3 times: notice that the comment order is not restored.
With all other avatar sort icons, the comment order is restored ok.

cases 2, 3

In https://github.com/gorhill/uMatrix/issues/968 or https://github.com/gorhill/uMatrix/issues/567,
if you click 3 times either the 'speak no evil monkey' avatar icon or the 'sort by +1' avatar icon , the initial comment order is not restored.
With the other avatar sort icons, the comment order is restored ok.

@Mottie
Copy link
Owner

Mottie commented Apr 12, 2018

Hi @darkred!

Eww yuck! Thanks for reporting this problem. I'll try to look into it soon...

@Mottie Mottie added the bug label Apr 12, 2018
@Mottie Mottie closed this as completed in 60ab556 Apr 12, 2018
@darkred
Copy link
Collaborator Author

darkred commented Apr 12, 2018

@Mottie Thank you for the quick response!

With the new version the comment order is indeed restored ok when clicking 3 times the 'speak no evil monkey' icon,
but unfortunately that's not the case when clicking 3 times the 'sort by +1' icon.

I've made screenshots of all 3 pages and compared them to their initial form(without the script).
Below are screenshots from the comparison program, at the scrolling point when the comments stop having their correct order:
left is without the script, right is with the script, after clicking 3 times the 'sort by +1' icon.

case 1

2018-04-12_185713

case 2

2018-04-12_185842

case 3

2018-04-12_190252

@Mottie
Copy link
Owner

Mottie commented Apr 12, 2018

Hmmm, ok I'll take a look again.

@Mottie Mottie reopened this Apr 12, 2018
@Mottie Mottie closed this as completed in e89ff2d May 8, 2018
@Mottie
Copy link
Owner

Mottie commented May 8, 2018

Sorry for taking so long to get this fixed!

@darkred
Copy link
Collaborator Author

darkred commented May 8, 2018

Np! Thanks a lot for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants