Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added config merge by wildcard #298

Merged
merged 4 commits into from Nov 28, 2018
Merged

Added config merge by wildcard #298

merged 4 commits into from Nov 28, 2018

Conversation

alenn-m
Copy link
Contributor

@alenn-m alenn-m commented Nov 27, 2018

I used github.com/imdario/mergo to merge 2 configs which are matched by wildcard. It solves the #147 issue.

@guardrails
Copy link

guardrails bot commented Nov 27, 2018 •
edited

⚠️ We detected security issues in this pull request:

Insecure File Management (2)

More info on how to fix Insecure File Management in Go.

@moul
Copy link
Owner

moul commented Nov 27, 2018

Hi @alenn-m

I think your solution works for hosts starting or ending with a *, however, it won't work with hosts that contain a * in the middle

@alenn-m
Copy link
Contributor Author

alenn-m commented Nov 27, 2018

Hi @moul
Yes, you are right. I added a fix for that. This is what I tested:

foo-*-bar
*-foo-bar
foo-bar-*
*-abc-*

And all of these iterations worked fine.

@moul moul merged commit 2eea23d into moul:master Nov 28, 2018
@github-actions
Copy link

🎉 This PR is included in version 2.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alenn-m @moul