Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build on macOS #476

Closed
austinbutler opened this issue Jan 3, 2022 · 3 comments · Fixed by #477
Closed

Fails to build on macOS #476

austinbutler opened this issue Jan 3, 2022 · 3 comments · Fixed by #477
Labels

Comments

@austinbutler
Copy link

Cause looks to be shirou/gopsutil#976.

I see the bot already had opened a PR to upgrade gopsutil with #467 but @moul you closed that. Not sure what the plan is so opening this to make you aware of the impact.

@moul
Copy link
Owner

moul commented Jan 3, 2022

yes, that’s because the dependency bot tried to upgrade a major version of a golang dependency (v2 -> v3)which requires updating the import path in the .go files, so I closed it since it can only break everything

I’ll make the bump manually to ensure everything works correctly

moul-bot pushed a commit that referenced this issue Jan 3, 2022
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul
Copy link
Owner

moul commented Jan 3, 2022

Hum, finally the automated PR should have been good since gopsutil is not using go mod :)

@moul moul mentioned this issue Jan 3, 2022
@moul moul closed this as completed in #477 Jan 3, 2022
@github-actions
Copy link

github-actions bot commented Jan 3, 2022

🎉 This issue has been resolved in version 2.12.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants