chore: fix missing deps + args in dockerfile (#569)

moul · Aug 29, 2022 · 7a9ffe2 · 7a9ffe2
1 parent 3fb7a4f
commit 7a9ffe2
Show file tree

Hide file tree

Showing 4 changed files with 36,767 additions and 11,203 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -3,7 +3,6 @@ ARG             BUILD_DATE
 ARG             VCS_REF
 ARG             VERSION
 
-
 # web build
 FROM            node:12-alpine as web-build
 RUN             npm i -g npm@8
@@ -12,8 +11,13 @@ WORKDIR         /app
 COPY            ./web/package*.json ./web/yarn.* ./
 RUN             npm install --legacy-peer-deps
 COPY            ./web/ ./
-RUN             npm run build
 
+# FIXME: avoid having those ARGs, make the runtime dynamic.
+ARG		        NODE_ENV=development
+ARG		        API_URL
+ARG		        GITHUB_CLIENT_ID
+ARG		        DEFAULT_TARGETS=moul/depviz-test
+RUN             GITHUB_CLIENT_ID=$GITHUB_CLIENT_ID API_URL=$API_URL NODE_ENV=$NODE_ENV DEFAULT_TARGETS=$DEFAULT_TARGETS npm run build
 
 # go build
 FROM            golang:1.19.0-alpine as go-build