Facebook API 2.2 will stop to work starting 27 March, 2017 (i.e. Facebook login is broken) / Fixed on master, need to be fixed on 2.5 and 2.6

[mouneyrac]

I have been alerted that the current install of the plugin will stop working with Facebook API 2.2 the 27 March (it was already not working for the facebook API 2.8 and later). Unhappily I do not foresee any fix to the issue soon. However I will be happy to merge a pull request (of course the code must work for people already using the plugin and for people that are going to use it).

[rabser]

Dear Jérôme, i arranged to work your unbeatable plugin with facebook API 2.8, but the work was done on plugin->version=2014120101 for moodle 2.x.
With the latest one, i'm sincerely lost in finding the same pieces of code, but i can share with you my changes in the old code, and maybe it's simpler for you putting the same changes in the latest plugin.

These are the simple changes that works for me in moodle 2.x:
``
diff --git a/auth.php b/auth.php
index 78815e9..8449a05 100644
--- a/auth.php
+++ b/auth.php
@@ -116,6 +116,8 @@ class auth_plugin_googleoauth2 extends auth_plugin_base {
$requestaccesstokenurl = 'https://graph.facebook.com/oauth/access_token';
$params['redirect_uri'] = $CFG->wwwroot . '/auth/googleoauth2/facebook_redirect.php';
$params['code'] = $authorizationcode;

•       $params['default_graph_version'] = 'v2.8';
  

•       $params['default_access_token'] = '{access_token}';
                 break;
             case 'messenger':
                 $params['client_id'] = get_config('auth/googleoauth2', 'messengerclientid');
  

@@ -166,6 +168,8 @@ class auth_plugin_googleoauth2 extends auth_plugin_base {
//$tokentype = $postreturnvalues->token_type;
break;
case 'facebook':

•                $accesstoken = json_decode($postreturnvalues)->access_token;
  

•       break;
             case 'github':
                 parse_str($postreturnvalues, $returnvalues);
                 $accesstoken = $returnvalues['access_token'];
  

[mouneyrac]

Thanks Sergio. Actually I have a great news Damyon (from HQ) fixed the problem. We can all thanks him there #234

I am now going to backport it and publish fix a new version on Moodle.org

[mouneyrac]

Actually Sergio I may push your code for 2.6 and 2.5, can you send me a pull request for either of them?

[rabser]

This morning (now is afternoon in italy) i faced up with the Moodle 3.x version of your plugin, cleaning up the code and using only the latest league oauth2 client with the standard providers ( http://oauth2-client.thephpleague.com/providers/league/ ) and with two official non standard providers (dropbox & microsoft). All of them (except instagram... ) are now running fine (tested with the latest api release of each social network) and a moodle v3.1.15 that i'm using for developing my platforms and integrations. For instagram i was going to put it as a new provider, but i'm missing the icon into the font... i have to remember how add an item to a font. The negative part of the work is the battlenet could not be integrated because the provider is too old, and vk provider seems not to be present along the provider list in http://oauth2-client.thephpleague.com/providers/thirdparty/ So now i've a running plugin for moodle 3 with these providers tested ok: 'google', 'facebook', 'github', 'linkedin', 'microsoft', 'dropbox' And i believe that the 99.99999% of the social network users are covered. For the pull request, i never did it before now, so i'm not sure that i know how to do, sorry. Il 29/03/2017 13:00, Jérôme Mouneyrac ha scritto:

…

Actually Sergio I may push your code for 2.6 and 2.5, can you send me a pull request for either of them? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#231 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIRpa9ez1te8o0VC6fFSVkkfc6ziMlQhks5rqjnjgaJpZM4MPejJ>.Web Bug from https://github.com/notifications/beacon/AIRpa8CzWyf1kElTP8yIPC9_8I3c4TUXks5rqjnjgaJpZM4MPejJ.gif {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mouneyrac/moodle-auth_googleoauth2","title":"mouneyrac/moodle-auth_googleoauth2","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in ***@***.*** in #231: Actually Sergio I may push your code for 2.6 and 2.5, can you send me a pull request for either of them? "}],"action":{"name":"View Issue","url":"#231 (comment)"}}}

-- ing. Sergio Rabellino Università degli Studi di Torino Dipartimento di Informatica Tecnico di Ricerca - Servizio ICT Tel +39-0116706701 Fax +39-011751603 C.so Svizzera , 185 - 10149 - Torino <http://www.di.unito.it>

[mouneyrac]

It is a really great news Sergio. Can you share your version on Github, the one working with the latest phpleague client? I doubt anyone use battlenet, I added it for a personal project. However I suppose VK is widely use in russia so it would be an issue to upgrade this plugin if there is no implementation for the latest phpleague lib. Anyway we should encourage people to work on the core oauth2 implementation that is coming in Moodle 3.3

Don't worry for the pull request, I'll take your fix and try it on 2.6.

Thanks,
Jerome

[mouneyrac]

I pushed a fix in STABLE_25 and STABLE_26, closing.
Thanks to @rabser and @damyon .

[rabser]

I own a gitlab installation where i do my develops. I did a new branch, called master3-unito with all the changes, but how i can send to your remote on github ? If i try a push (obviously) i get a permission denied. which is the correct git command to send this branch to you ? Il 29/03/2017 13:47, Jérôme Mouneyrac ha scritto:

…

It is a really great news Sergio. Can you share your version on Github, the one working with the latest phpleague client? I doubt anyone use battlenet, I added it for a personal project. However I suppose VK is widely use in russia so it would be an issue to upgrade this plugin if there is no implementation for the latest phpleague lib. Anyway we should encourage people to work on the core oauth2 implementation that is coming in Moodle 3.3 Don't worry for the pull request, I'll take your fix and try it on 2.6. Thanks, Jerome — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#231 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIRpa0WoaD-CR8lmF8cARcrXIernWjNPks5rqkS_gaJpZM4MPejJ>.Web Bug from https://github.com/notifications/beacon/AIRpawwy_4OYZwN6bH-EF1DbxYHTgIMMks5rqkS_gaJpZM4MPejJ.gif {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mouneyrac/moodle-auth_googleoauth2","title":"mouneyrac/moodle-auth_googleoauth2","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in ***@***.*** in #231: It is a really great news Sergio. Can you share your version on Github, the one working with the latest phpleague client? I doubt anyone use battlenet, I added it for a personal project. However I suppose VK is widely use in russia so it would be an issue to upgrade this plugin if there is no implementation for the latest phpleague lib. Anyway we should encourage people to work on the core oauth2 implementation that is coming in Moodle 3.3\r\n\r\nDon't worry for the pull request, I'll take your fix and try it on 2.6.\r\n\r\nThanks,\r\nJerome"}],"action":{"name":"View Issue","url":"#231 (comment)"}}}

-- ing. Sergio Rabellino Università degli Studi di Torino Dipartimento di Informatica Tecnico di Ricerca - Servizio ICT Tel +39-0116706701 Fax +39-011751603 C.so Svizzera , 185 - 10149 - Torino <http://www.di.unito.it>