Fix facebook #234
Merged
Fix facebook #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Daymon I merged it :) |
|
I will test it later tonight if I have some time and push it to all versions and on Moodle.org plugin rep. |
|
I tested on an old install that I confirmed was broken and it now works. I am backporting it and pushing an update on Moodle.org. I'll also comment on the plugin settings admin page to recommend to switch to Moodle 3.3 and the core oauth2 plugins. Thanks Damyon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jerome - I saw the facebook issue reported in this forums - here is a quick fix.