Related applications review with proposals #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -308,7 +308,7 @@ | |||
| <li>Otherwise, return <code>false</code>. | |||
| </li> | |||
| </ol> | |||
| <div class="issue" title="🐒 Monkey patch"> | |||
| <div class="issue" title="🐒 Monkey patch"> | |||
There was a problem hiding this comment.
@anssiko, this change is unrelated to the feature and the issue being addressed. Do you mind reverting this? We can do it as a separate fix
There was a problem hiding this comment.
My editor did not co-operate, so I was forced to convert it to an HTML entity on the same pass. Sorry.
|
Thank you for your comments Anssi. They look good to me. |
mounirlamouri
added a commit
that referenced
this pull request
Apr 7, 2015
Related applications review with proposals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.