Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect hull for points on a square pattern #24

Closed
andreesteve opened this issue Oct 31, 2021 · 1 comment · Fixed by #25
Closed

Incorrect hull for points on a square pattern #24

andreesteve opened this issue Oct 31, 2021 · 1 comment · Fixed by #25
Labels
bug Something isn't working

Comments

@andreesteve
Copy link
Collaborator

Points distributed in a square pattern now have an incorrect hull (left side is v1 delaunator-rs, and right side is the latest delaunator js):

image

Here's the result for v0.2.1 that shows the hull matched the js result

image

Likely a regression from the robust checks.
@andreesteve andreesteve added the bug Something isn't working label Oct 31, 2021
@andreesteve
Copy link
Collaborator Author

andreesteve commented Oct 31, 2021 •
edited
Loading

Here's the smallest repro I found far.

andreesteve added a commit that referenced this issue Oct 31, 2021
@andreesteve
Fixes invalid hull on collinear points
a40b6c0 
Fixes #24
@andreesteve andreesteve mentioned this issue Oct 31, 2021
Merged
andreesteve added a commit that referenced this issue Oct 31, 2021
@andreesteve
Fixes invalid hull on collinear points (#25)
81e58c6 
Fixes #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes invalid hull on collinear points mourner/delaunator-rs
1 participant
@andreesteve