Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed panic when NaN is passed #28

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Fixed panic when NaN is passed #28

merged 2 commits into from
Mar 20, 2023

Conversation

AndriBaal
Copy link
Contributor

Previously, the triangulation panicked when NaN was passed because there was no fall back to equal in the sort comparison.

@AndriBaal AndriBaal mentioned this pull request Mar 20, 2023
Closed
mourner
mourner requested changes Mar 20, 2023
View reviewed changes
Copy link
Owner

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, just needs a tiny fix to pass the Lint stage.

@AndriBaal AndriBaal requested a review from mourner March 20, 2023 19:02
@mourner mourner merged commit 4e17b93 into mourner:master Mar 20, 2023
@mourner mourner mentioned this pull request Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndriBaal @mourner