Encourage override of toBBox, compareMinX, compareMinY for CSP issues #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where the Content Security Policy (or other) disallows the use of eval and related functions (e.g. browser extensions), the toBBox, compareMinX, and compareMinY methods can be overridden.
|
Looks good to me. Thanks! |
mourner
added a commit
that referenced
this pull request
Nov 21, 2013
Encourage override of toBBox, compareMinX, compareMinY for CSP issues
|
Will publish the new version to NPM once this pull is sorted: #11 |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where the Content Security Policy (or other) disallows the use of eval and related functions (e.g. browser extensions), the
toBBox,compareMinX, andcompareMinYmethods can be overridden.This makes it so the
Functionconstructor is only used if a custom format is supplied. Default implementations oftoBBox,compareMinX, andcompareMinYare run otherwise.This is an alternative to #12 (and doesn't break the current API).