Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add height to getTimes as optional parameter #137

Merged
merged 1 commit into from
Dec 27, 2019
Merged

add height to getTimes as optional parameter #137

merged 1 commit into from
Dec 27, 2019

Conversation

ryanp54
Copy link
Contributor

@ryanp54 ryanp54 commented Dec 27, 2019

Resolves: #104

mourner
mourner approved these changes Dec 27, 2019
View reviewed changes
Copy link
Owner

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks so much for the PR!

@mourner mourner merged commit 031c4ad into mourner:master Dec 27, 2019
@mourner mourner mentioned this pull request Dec 27, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Take into account altitude for computation of sunrise/sunset ...
2 participants
@ryanp54 @mourner