Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Niffy should accept and test multiple resolutions #2

Closed
mousemke opened this issue Sep 15, 2017 · 0 comments
Closed

[Feature] Niffy should accept and test multiple resolutions #2

mousemke opened this issue Sep 15, 2017 · 0 comments

Comments

@mousemke
Copy link
Owner

What needs to get done?

  • niffy should take an object as an option with different resolutions to test all. example:
const niffyTargets = {
  xl: [1205,600],
  l: [965, 600],
  m: [605, 600],
  s: [325, 600]
}

const niffy = new Niffy( url1, url2, { 
    targets: niffyTargets,
    pngPath: path.resolve(process.cwd(), `./niffy`)
 });

in tihs case, it whould output diff images to the following directories:

  • ./niffy/xl
  • ./niffy/l
  • ./niffy/m
  • ./niffy/s

Why does it need to get done?

it saves everyone making their own implementation of the loop and streamlines the process

How do I do it?

loop nightmare over the keys

@mousemke mousemke changed the title Niffy should accept and test multiple resolutions [Feature] Niffy should accept and test multiple resolutions Sep 15, 2017
mousemke pushed a commit that referenced this issue Sep 18, 2017
mousemke pushed a commit that referenced this issue Sep 18, 2017
mousemke added a commit that referenced this issue Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant