Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Expose wait #4

Closed
mousemke opened this issue Sep 21, 2017 · 1 comment
Closed

[feature] Expose wait #4

mousemke opened this issue Sep 21, 2017 · 1 comment

Comments

@mousemke
Copy link
Owner

mousemke commented Sep 21, 2017

What needs to get done?

  • the wait method from nightmare should be exposed.

Why does it need to get done?

before(function*() {
  yield niffy.goto('/', function*(nightmare) {
    yield nightmare.wait(3000);
  });
});

it seems odd that you would have to go through another call just to use wait through a callback. this exposes it to the niffy object

before(function*() {
  yield niffy.wait(3000);
});

How do I do it?

simply exposing it should do the trick

  /**
   * exposes the nightmare wait fubction
   *
   * @param {String} target selector of ms
   */
  * wait( target ){
      this.nightmare.wait( target );
    }
  }
@mousemke
Copy link
Owner Author

segmentio#15

mousemke pushed a commit that referenced this issue Sep 21, 2017
mousemke pushed a commit that referenced this issue Sep 21, 2017
mousemke added a commit that referenced this issue Sep 21, 2017
GH-4 exposed nightmare wait to niffy
mousemke pushed a commit that referenced this issue Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant