Skip to content

Commit

Permalink
🐛 fix regression on embedded layout after PR RocketChat#13471
Browse files Browse the repository at this point in the history
  • Loading branch information
moustachu committed Feb 19, 2019
1 parent c0fa1e7 commit 9c07163
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 20 deletions.
1 change: 0 additions & 1 deletion client/routes/router.js
Original file line number Diff line number Diff line change
Expand Up @@ -178,4 +178,3 @@ FlowRouter.notFound = {
BlazeLayout.render('pageNotFound');
},
};

21 changes: 2 additions & 19 deletions packages/rocketchat-ui-utils/client/lib/openRoom.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
import { Meteor } from 'meteor/meteor';
import { Tracker } from 'meteor/tracker';
import { Blaze } from 'meteor/blaze';
import { Template } from 'meteor/templating';
import { FlowRouter } from 'meteor/kadira:flow-router';
import { BlazeLayout } from 'meteor/kadira:blaze-layout';
import { Session } from 'meteor/session';
import { RoomManager, fireGlobalEvent, readMessage, RoomHistoryManager } from '..';
import { Layout, RoomManager, fireGlobalEvent, readMessage, RoomHistoryManager } from '..';
import { ChatSubscription, Rooms } from 'meteor/rocketchat:models';
import { settings } from 'meteor/rocketchat:settings';
import { callbacks } from 'meteor/rocketchat:callbacks';
Expand All @@ -14,21 +12,6 @@ import _ from 'underscore';

window.currentTracker = undefined;

let loadingDom;
function getDomOfLoading() {
if (loadingDom) {
return loadingDom;
}

loadingDom = document.createElement('div');
const contentAsFunc = (content) => () => content;

const template = Blaze._TemplateWith({ }, contentAsFunc(Template.loading));
Blaze.render(template, loadingDom);

return loadingDom;
}

function replaceCenterDomBy(dom) {
const mainNode = document.querySelector('.main-content');
if (mainNode) {
Expand All @@ -53,7 +36,7 @@ export const openRoom = function(type, name) {
}

if (RoomManager.open(type + name).ready() !== true) {
replaceCenterDomBy(getDomOfLoading());
BlazeLayout.render('main', { modal: Layout.isEmbedded(), center: 'loading' });
return;
}
if (window.currentTracker) {
Expand Down

0 comments on commit 9c07163

Please sign in to comment.