getQuery with hash before #227
Conversation
| @@ -4,7 +4,7 @@ define(function () { | |||
| * Gets full query as string with all special chars decoded. | |||
| */ | |||
| function getQuery(url) { | |||
| url = url.replace(/#.*/, ''); //removes hash (to avoid getting hash query) | |||
| url = url.replace(/#.*\?/, '?'); //removes hash (to avoid getting hash query) | |||
There was a problem hiding this comment.
instead of replacing the RegExp you could simply delete this line if you want to allow getting the ?.+ after the #.
this was there because in some cases you might have URLs like: http://example.com/foo?bar=true#lorem?ipsum=dolor, so what should be the result of getQuery?
There was a problem hiding this comment.
The correct is query to come before the hash, but, on a SPA, a URL with query string before it's weird:
https://example.com/#/users/
https://example.com/#/users/?page=2
The solution to my case can be:
https://example.com/#/users/page-2/
But I wonder if the case should be valid only "?bar=true" or "?bar=true&ipsum=dolor"
http://example.com/foo?bar=true#lorem?ipsum=dolor
There was a problem hiding this comment.
I think it should grab the first query string and ignore the second (if string contains 2). so let's just delete the line 7 and add more tests to show behavior when we have multiple queries.
referent #226