Skip to content

Commit

Permalink
FIXME: qwebelement depends on jsc and jsc does not use rtti
Browse files Browse the repository at this point in the history
  • Loading branch information
@mnutt
mnutt committed Jun 28, 2023
1 parent f99e7a4 commit 2caecbb
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Source/WebKitLegacy/PlatformQt.cmake
View file
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,8 @@ endif ()
if (COMPILER_IS_GCC_OR_CLANG)
set_source_files_properties(
qt/Api/qwebdatabase.cpp
qt/Api/qwebelement.cpp
# FIXME
#qt/Api/qwebelement.cpp

This comment has been minimized.

Sign in to view

Copy link
@annulen

annulen Jul 1, 2023

As you may guess, this build fix is not a proper solution. Idea behind enabling -frtti on these files is to provide compatibility with user code that uses public APIs and compiles with enabled RTTI (because using no-rtti classes in rtti code leads to linking errors similar to what you've seen)
qt/Api/qwebfullscreenrequest.cpp
qt/Api/qwebhistory.cpp
qt/Api/qwebhistoryinterface.cpp
Expand Down

0 comments on commit 2caecbb

Please sign in to comment.